Refactoring

* splits compensation/models.py into subpackage
* renames base objects by adding suffix Mixin

konova/forms.py

@@ -22,7 +22,7 @@ from django.utils import timezone
 from django.utils.translation import gettext_lazy as _
 
 from konova.contexts import BaseContext
-from konova.models import BaseObject, Geometry, RecordableObject
+from konova.models import BaseObject, Geometry, RecordableObjectMixin
 from konova.settings import DEFAULT_SRID
 from konova.utils.message_templates import FORM_INVALID
 from user.models import UserActionLogEntry, UserAction
@@ -290,7 +290,7 @@ class SimpleGeomForm(BaseForm):
             geometry.geom = self.cleaned_data.get("geom", MultiPolygon(srid=DEFAULT_SRID))
             geometry.modified = action
             geometry.save()
-        except (AttributeError) as e:
+        except AttributeError:
             # No geometry or linked instance holding a geometry exist --> create a new one!
             geometry = Geometry.objects.create(
                 geom=self.cleaned_data.get("geom", MultiPolygon(srid=DEFAULT_SRID)),
@@ -446,7 +446,7 @@ class RecordModalForm(BaseModalForm):
             self.form_title = _("Unrecord data")
             self.form_caption = _("I, {} {}, confirm that this data must be unrecorded.").format(self.user.first_name, self.user.last_name)
 
-        if not isinstance(self.instance, RecordableObject):
+        if not isinstance(self.instance, RecordableObjectMixin):
             raise NotImplementedError
 
     def is_valid(self):