#36 Quality checks

* adds AbstractQualityChecker as base for all quality checker instances
* adds InterventionQualityChecker, inheriting from AbstractQualityChecker
* adds functionality to InterventionQualityChecker
* adds/updates translations

intervention/models.py

@@ -16,6 +16,7 @@ from codelist.models import KonovaCode
 from codelist.settings import CODELIST_REGISTRATION_OFFICE_ID, CODELIST_CONSERVATION_OFFICE_ID, CODELIST_LAW_ID, \
     CODELIST_PROCESS_TYPE_ID
 from intervention.managers import InterventionManager
+from intervention.utils.quality import InterventionQualityChecker
 from konova.models import BaseObject, Geometry, UuidModel, BaseResource, AbstractDocument, \
     generate_document_file_upload_path
 from konova.settings import DEFAULT_SRID_RLP, LANIS_LINK_TEMPLATE, LANIS_ZOOM_LUT
@@ -56,7 +57,6 @@ class ResponsibilityData(UuidModel):
     conservation_file_number = models.CharField(max_length=1000, blank=True, null=True)
     handler = models.CharField(max_length=500, null=True, blank=True, help_text="Refers to 'Eingriffsverursacher' or 'Maßnahmenträger'")
 
-
     def __str__(self):
         return "ZB: {} | ETS: {} | Handler: {}".format(
             self.registration_office,
@@ -296,62 +296,15 @@ class Intervention(BaseObject):
                 pass
         super().delete(using, keep_parents)
 
-    def quality_check(self) -> list:
+    def quality_check(self) -> InterventionQualityChecker:
         """ Quality check
 
         Returns:
             ret_msgs (list): Holds error messages
         """
-        ret_msgs = []
-
-        self._check_quality_responsible_data(ret_msgs)
-        self._check_quality_legal_data(ret_msgs)
-
-        # ToDo: Extend for more!
-
-        return ret_msgs
-
-    def _check_quality_responsible_data(self, ret_msgs: list):
-        """ Checks data quality of related ResponsibilityData
-
-        Args:
-            ret_msgs (dict): Holds error messages
-
-        Returns:
-
-        """
-        try:
-            # Check for file numbers
-            if not self.responsible.registration_file_number or len(self.responsible.registration_file_number) == 0:
-                ret_msgs.append(_("Registration office file number missing"))
-
-            if not self.responsible.conservation_file_number or len(self.responsible.conservation_file_number) == 0:
-                ret_msgs.append(_("Conservation office file number missing"))
-        except AttributeError:
-            # responsible data not found
-            ret_msgs.append(_("Responsible data missing"))
-
-    def _check_quality_legal_data(self, ret_msgs: list):
-        """ Checks data quality of related LegalData
-
-        Args:
-            ret_msgs (dict): Holds error messages
-
-        Returns:
-
-        """
-        try:
-            # Check for a revocation
-            if self.legal.revocation:
-                ret_msgs.append(_("Revocation exists"))
-
-            if self.legal.registration_date is None:
-                ret_msgs.append(_("Registration date missing"))
-
-            if self.legal.binding_date is None:
-                ret_msgs.append(_("Binding on missing"))
-        except AttributeError:
-            ret_msgs.append(_("Legal data missing"))
+        checker = InterventionQualityChecker(obj=self)
+        checker.run_check()
+        return checker
 
     def get_LANIS_link(self) -> str:
         """ Generates a link for LANIS depending on the geometry